sfeed_curses

commit 8314752e3afffc554e9ee298932fe67dec122ffe
parent e1b7e083669b13f335e4a388187e17b9c911a8d0
Author: Hiltjo Posthuma <hiltjo@codemadness.org>
Date:   Thu, 16 Jul 2020 17:31:26 +0200

fork: kill some lines and make the flow easier to read

Diffstat:
M
sfeed_curses.c
 | 
14
++++++--------

1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/sfeed_curses.c b/sfeed_curses.c
@@ -518,10 +518,10 @@ pipeitem(const char *cmd, struct item *item, int wantoutput)
 
 	if (wantoutput)
 		cleanup();
+
 	switch ((pid = fork())) {
 	case -1:
 		err(1, "fork");
-		return;
 	case 0:
 		if (!wantoutput) {
 			dup2(devnullfd, 1);
@@ -540,16 +540,15 @@ pipeitem(const char *cmd, struct item *item, int wantoutput)
 		status = pclose(fp);
 		status = WIFEXITED(status) ? WEXITSTATUS(status) : 127;
 		_exit(status);
-		break;
 	default:
 		while ((wpid = wait(NULL)) >= 0 && wpid != pid)
 			;
-	}
 
-	if (wantoutput) {
-		updatesidebar(onlynew);
-		updatetitle();
-		init();
+		if (wantoutput) {
+			updatesidebar(onlynew);
+			updatetitle();
+			init();
+		}
 	}
 }
 
@@ -559,7 +558,6 @@ plumb(const char *cmd, char *url)
 	switch (fork()) {
 	case -1:
 		err(1, "fork");
-		return;
 	case 0:
 		dup2(devnullfd, 1);
 		dup2(devnullfd, 2);